walterddr commented on a change in pull request #8303: [FLINK-12343]
[flink-yarn] add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r326906042
##########
File path:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
##########
@@ -648,6 +699,23 @@ private static void start(YarnConfiguration conf, String
principal, String keyta
File targetTestClassesFolder = new
File("target/test-classes");
writeYarnSiteConfigXML(conf, targetTestClassesFolder);
+
+ LOG.info("Starting up MiniDFSCluster");
+ if (miniDFSCluster == null) {
+
+ Configuration hdfsConfiguration = new
Configuration();
+
hdfsConfiguration.set(MiniDFSCluster.HDFS_MINIDFS_BASEDIR,
tmpHDFS.getRoot().getAbsolutePath());
+ if (principal != null && keytab != null) {
+
populateHDFSSecureConfigurations(hdfsConfiguration, principal, keytab);
+ }
+ miniDFSCluster = new
MiniDFSCluster.Builder(hdfsConfiguration).numDataNodes(3).build();
+ miniDFSCluster.waitClusterUp();
+
+ hdfsConfiguration =
miniDFSCluster.getConfiguration(0);
+ writeHDFSCoreSiteConfigXML(hdfsConfiguration,
targetTestClassesFolder);
+
YARN_CONFIGURATION.addResource(hdfsConfiguration);
+ }
Review comment:
+1. I think we can have a separated test case specifically just for the AM
startup (jobmanager, filesystem, etc).
However, do you think we can create a follow up ticket for the refactoring?
@tillrohrmann
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
