bowenli86 commented on a change in pull request #9689: [FLINK-7151] add a basic
function ddl
URL: https://github.com/apache/flink/pull/9689#discussion_r327338523
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -351,6 +353,21 @@ public void sqlUpdate(String stmt) {
DropTableOperation dropTableOperation =
(DropTableOperation) operation;
ObjectIdentifier objectIdentifier =
catalogManager.qualifyIdentifier(dropTableOperation.getTableName());
catalogManager.dropTable(objectIdentifier,
dropTableOperation.isIfExists());
+ } else if (operation instanceof CreateFunctionOperation) {
+ CreateFunctionOperation createFunctionOperation =
(CreateFunctionOperation) operation;
+ ObjectIdentifier objectIdentifier =
+
catalogManager.qualifyIdentifier(createFunctionOperation.getFunctionPath());
+ catalogManager.createFunction(
+ createFunctionOperation.getCatalogFunction(),
+ objectIdentifier,
+ createFunctionOperation.isIgnoreIfExists());
+ } else if (operation instanceof DropTableOperation) {
Review comment:
should be DropFunctionOperation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
