GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime]
Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r327640716
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -1129,6 +1157,9 @@ void failGlobalIfExecutionIsStillRunning(Throwable
cause, ExecutionAttemptID fai
* @param t The exception that caused the failure.
*/
public void failGlobal(Throwable t) {
+ if (!isLegacyScheduling()) {
+ ExceptionUtils.rethrow(t);
Review comment:
> If we'd like to terminate the JVM, why not do it right in the place the
fatal error happens?
- It's easier to write unit test that assert the presence of an exception
rather than termination of the JVM
- There can be unforeseeable exceptions caused by bugs (e.g., NPE,
`checkState` violations), which should be handled the same way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
