1u0 commented on a change in pull request #9717: [FLINK-14044] [runtime] Reducing synchronization in AsyncWaitOperator URL: https://github.com/apache/flink/pull/9717#discussion_r328077048
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/queue/StreamElementQueue.java ########## @@ -19,68 +19,56 @@ package org.apache.flink.streaming.api.operators.async.queue; import org.apache.flink.annotation.Internal; +import org.apache.flink.streaming.api.functions.async.ResultFuture; +import org.apache.flink.streaming.api.operators.TimestampedCollector; import org.apache.flink.streaming.api.operators.async.AsyncWaitOperator; +import org.apache.flink.streaming.runtime.streamrecord.StreamElement; -import java.util.Collection; +import java.util.List; +import java.util.Optional; /** - * Interface for blocking stream element queues for the {@link AsyncWaitOperator}. + * Interface for a non-blocking stream element queues for the {@link AsyncWaitOperator}. Review comment: Suggestion: remove "blocking/non-blocking" mention at all, as the queues are not thread safe any more and supposed to be used by one thread. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services