hequn8128 commented on a change in pull request #9766: [FLINK-14018][python]
Add Python building blocks to make sure the basic functionality of Python
ScalarFunction could work
URL: https://github.com/apache/flink/pull/9766#discussion_r328537992
##########
File path:
flink-python/src/main/java/org/apache/flink/python/AbstractPythonFunctionRunner.java
##########
@@ -280,13 +281,16 @@ private static String randomString(Random random) {
*/
protected RunnerApi.Environment createPythonExecutionEnvironment() {
if (pythonEnv.getExecType() == PythonEnv.ExecType.PROCESS) {
- final Map<String, String> env = new HashMap<>(2);
- env.put("python", pythonEnv.getPythonExec());
+ final Map<String, String> env = new HashMap<>(1);
Review comment:
We don't need this env. Just pass null to the
`Environments.createProcessEnvironment()` method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
