tillrohrmann commented on a change in pull request #9760:
[FLINK-13982][runtime] Implement memory calculation logics
URL: https://github.com/apache/flink/pull/9760#discussion_r329066092
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -37,6 +37,24 @@
private TaskExecutorResourceUtils() {}
+ //
------------------------------------------------------------------------
+ // Generating JVM Parameters
+ //
------------------------------------------------------------------------
+
+ public static String generateJvmParametersStr(final
TaskExecutorResourceSpec taskExecutorResourceSpec) {
+ final MemorySize jvmHeapSize =
taskExecutorResourceSpec.getFrameworkHeapSize()
+ .add(taskExecutorResourceSpec.getTaskHeapSize())
+
.add(taskExecutorResourceSpec.getOnHeapManagedMemorySize());
+ final MemorySize jvmDirectSize =
taskExecutorResourceSpec.getTaskOffHeapSize()
Review comment:
What about `getOffHeapManagedMemorySize`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
