zhuzhurk commented on a change in pull request #9788: [FLINK-14259] Introduce JobManagerRunner interface URL: https://github.com/apache/flink/pull/9788#discussion_r329311362
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/TestingJobManagerRunnerFactory.java ########## @@ -82,10 +83,10 @@ public JobManagerRunner createJobManagerRunner( } else { jobGraphFuture.complete(jobGraph); - final JobManagerRunner mock = mock(JobManagerRunner.class); Review comment: It can remain to be `JobManagerRunner` here. But I think it's fine to since PR#9789 will refactor it later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services