TisonKun commented on a change in pull request #9788: [FLINK-14259] Introduce JobManagerRunner interface URL: https://github.com/apache/flink/pull/9788#discussion_r329315033
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java ########## @@ -629,7 +630,7 @@ public void testJobSubmissionErrorAfterJobRecovery() throws Exception { } /** - * Tests that a blocking {@link JobManagerRunner} creation, e.g. due to blocking FileSystem access, + * Tests that a blocking {@link JobManagerRunnerImpl} creation, e.g. due to blocking FileSystem access, Review comment: I think it is modified by auto refactor tools. In document we can only document interface instead of implementation. Thus +1 replace this-alike `JobManagerRunnerImpl` in document with `JobManagerRunner`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services