JingsongLi commented on a change in pull request #9796: 
[FLINK-14253][table-planner-blink] Add hash distribution and sort grouping only 
when dynamic partition insert
URL: https://github.com/apache/flink/pull/9796#discussion_r329400159
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/calcite/LogicalSink.scala
 ##########
 @@ -37,11 +37,12 @@ final class LogicalSink(
     traitSet: RelTraitSet,
     input: RelNode,
     sink: TableSink[_],
-    sinkName: String)
+    sinkName: String,
+    val staticPartitions: Map[String, String])
 
 Review comment:
   Yes, actually the sink concept from `CatalogSinkModifyOperation` is `insert 
into ....` in SQL. So I think Sink contains static partitions information is 
not strange.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to