wuchong commented on a change in pull request #9781: [FLINK-14098] Support
multiple statements for TableEnvironment.
URL: https://github.com/apache/flink/pull/9781#discussion_r331749718
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/delegation/Planner.java
##########
@@ -65,7 +65,7 @@
* @param operationPreConsumer pre consumer for specific operations
* @return parsed queries as trees of relational {@link Operation}s
*/
- List<Operation> parse(String statement, Consumer<Operation>
operationPreConsumer);
+ Iterable<Operation> parse(String statement, Consumer<Operation>
operationPreConsumer);
Review comment:
I think once we have the `Iterable` return type, we don't need the Consumer
anymore. The returned `Iterable` can be a lazy result (we should update the
implementation of this method to adapt to return a lazy result).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
