[ 
https://issues.apache.org/jira/browse/FLINK-14302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941640#comment-16941640
 ] 

Wei-Che Wei edited comment on FLINK-14302 at 10/7/19 6:59 AM:
--------------------------------------------------------------

Sorry for that I didn't notice that the contribution flow has changed. And I 
already sent a PR for this issue, but couldn't assign it to myself.

Hi [~becket_qin] 
 If you have free time, please help me to verify if the issue in mailing list 
thread I mentioned is a bug, and should it be fix like I suggested?
 If this is a bug, and the solution is good to you, please assign this Jira 
issue to me. Thanks.


was (Author: tonywei):
Sorry for that I didn't notice that the contribution flow has changed. And I 
already sent a PR for this issue, but couldn't assign it to myself.

Hi [~jqin],
If you have free time, please help me to verify if the issue in mailing list 
thread I mentioned is a bug, and should it be fix like I suggested?
If this is a bug, and the solution is good to you, please assign this Jira 
issue to me. Thanks.

> FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if 
> `newPartitionsInTransaction` is empty when enable EoS
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-14302
>                 URL: https://issues.apache.org/jira/browse/FLINK-14302
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Kafka
>            Reporter: Wei-Che Wei
>            Assignee: Wei-Che Wei
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> As the survey in this mailing list thread [1], kafka server will bind the 
> error with topic-partition list when it handles `AddPartitionToTxnRequest`. 
> So when the request body contains no topic-partition, the error won't be sent 
> back to kafka producer client. Moreover, it producer internal api, it always 
> check if `newPartitionsInTransaction` is empty before sending 
> ADD_PARTITIONS_TO_TXN request to kafka cluster. We should apply it as well if 
> you need to explicitly call it in the first commit phase of two-phase commit 
> sink.
> [1] 
> [http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Kafka-producer-failed-with-InvalidTxnStateException-when-performing-commit-transaction-td29384.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to