TisonKun commented on a change in pull request #9861: [FLINK-14237][yarn] No
need to rename shipped Flink jar
URL: https://github.com/apache/flink/pull/9861#discussion_r332907925
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -813,7 +813,7 @@ private ApplicationReport startAppMaster(
// Setup jar for ApplicationMaster
Path remotePathJar = setupSingleLocalResource(
- "flink.jar",
+ flinkJarPath.getName(),
Review comment:
We call `Path.getName` where `Path` is `org.apache.hadoop.fs.Path` so I
think we don't fail into this case. BTW, we already ship user jars in this
pattern. So if this is valid, we also suffer from the risk that user jars
contains characters that aren't supported by the target filesystem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
