hequn8128 commented on a change in pull request #9855: [FLINK-14306][python]
Add the code-generated flink_fn_execution_pb2.py to the codebase
URL: https://github.com/apache/flink/pull/9855#discussion_r332908845
##########
File path: flink-python/pyflink/gen_protos.py
##########
@@ -137,10 +137,51 @@ def _install_grpcio_tools_and_generate_proto_files():
if install_obj.install_purelib != install_obj.install_platlib:
sys.path.append(install_obj.install_platlib)
try:
- generate_proto_files()
+ generate_proto_files(force, output_dir)
finally:
sys.stderr.flush()
+def _add_license_header(dir, file_name):
+ with open(os.path.join(dir, file_name), 'r') as original_file:
+ original_data = original_file.read()
+ tmp_file_name = file_name + '.tmp'
+ with open(os.path.join(dir, tmp_file_name), 'w') as tmp_file:
+ tmp_file.write(
+
'################################################################################\n'
+ '# Licensed to the Apache Software Foundation (ASF) under
one\n'
+ '# or more contributor license agreements. See the NOTICE
file\n'
+ '# distributed with this work for additional information\n'
+ '# regarding copyright ownership. The ASF licenses this
file\n'
+ '# to you under the Apache License, Version 2.0 (the\n'
+ '# "License"); you may not use this file except in
compliance\n'
+ '# with the License. You may obtain a copy of the License
at\n'
+ '#\n'
+ '# http://www.apache.org/licenses/LICENSE-2.0\n'
+ '#\n'
+ '# Unless required by applicable law or agreed to in writing,
software\n'
+ '# distributed under the License is distributed on an "AS IS"
BASIS,\n'
+ '# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
express or implied.\n'
+ '# See the License for the specific language governing
permissions and\n'
+ '# limitations under the License.\n'
+
'################################################################################\n'
+ )
+ tmp_file.write(original_data)
+ os.rename(os.path.join(dir, tmp_file_name), os.path.join(dir,
file_name))
+
+
+def _check_grpcio_tools_version():
Review comment:
Call this method after the `grpcio-tools` has been installed? i.e., call it
after line 90. In this way, the method can be simplified a bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
