1u0 commented on a change in pull request #9818: [FLINK-14289][runtime] Remove
Optional fields from RecordWriter relevant classes
URL: https://github.com/apache/flink/pull/9818#discussion_r329422367
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriter.java
##########
@@ -40,7 +39,7 @@
public final class BroadcastRecordWriter<T extends IOReadableWritable> extends
RecordWriter<T> {
/** The current buffer builder shared for all the channels. */
- private Optional<BufferBuilder> bufferBuilder = Optional.empty();
+ private BufferBuilder bufferBuilder;
Review comment:
Annotate with `@Nullable`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
