tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#discussion_r333655871
########## File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java ########## @@ -260,6 +263,189 @@ text("\"ip\" - uses host's ip address as binding address")) .build()); + // ------------------------------------------------------------------------ + // Memory Options + // ------------------------------------------------------------------------ + + /** + * Total Process Memory size for the TaskExecutors. + */ + public static final ConfigOption<String> TOTAL_PROCESS_MEMORY = + key("taskmanager.memory.total-process.size") + .noDefaultValue() + .withDescription("Total Process Memory size for the TaskExecutors. This includes all the memory that a" + + " TaskExecutor consumes, consisting of Total Flink Memory, JVM Metaspace, and JVM Overhead. On" + + " containerized setups, this value is automatically configured to the size of the container."); Review comment: Not sure whether the last sentence makes sense with the `automatically configured`. I guess it should say that in a containerized environment, you should set this value to the container memory. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services