klion26 commented on a change in pull request #9873: [FLINK-14336][DataStream] Log Exception for failed checkpoint on TaskExecutor side URL: https://github.com/apache/flink/pull/9873#discussion_r333807609
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java ########## @@ -1115,6 +1115,12 @@ public void run() { checkpointMetaData.getCheckpointId()); } } catch (Exception e) { + if (LOG.isDebugEnabled()) { + LOG.debug("{} - asynchronous part of checkpoint {} could not be completed.", Review comment: First, I want to use WARN or even ERROR level, but the frequency of checkpoint may be too small, we may have logging flood if use INFO or above log level, so I used debug here. If we do not have so frequent checkpoints, we can configure the log level of log-4j properties to show this log. what do you think about this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services