pnowojski commented on a change in pull request #9879: [FLINK-14300][runtime,
test] Add test making sure that RecordWriter is properly closed in case of
early StreamTask failure
URL: https://github.com/apache/flink/pull/9879#discussion_r333903331
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamConfigChainer.java
##########
@@ -109,14 +132,14 @@ private void head(StreamOperator<?> headOperator,
OperatorID headOperatorID) {
tailConfig.setStateKeySerializer(inputSerializer);
}
tailConfig.setChainIndex(chainIndex);
+ tailConfig.setBufferTimeout(bufferTimeout);
Review comment:
I needed the non-zero value for my new test, so that the `OutputFlusher`
thread is started.
Yes, I noticed the test failures caused by this. I will think how to address
them. Previous behaviour was I think incorrect (`StreamConfigChainer` was
ignoring the value passed from `StreamConfig`)
edit: I've fixed the failing tests by unifying the `setBufferTimeout`
setting in both modes of setuping `StreamTaskTestHarness`: with and without
`StreamConfigChainer`. I hope that it won't fail some of the other tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
