buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL]
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334265001
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
##########
@@ -57,12 +60,15 @@
private final SqlNodeList propertyList;
+ @Nullable
Review comment:
@danny0405 `primaryKeyList` and `uniqueKeysList` are null if they're not
defined because we define them in parserImpls.ftl as null by default, which is
different with other fields like propertyList and partitionColumns. Please
correct me if I'm wrong.
@wuchong I kind of misunderstand your comments in jira. I thought we should
keep `primaryKeyList` and `uniqueKeysList` 's default value. I will make them
consistent with propertyList and partitionColumns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
