[
https://issues.apache.org/jira/browse/FLINK-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiayi Liao updated FLINK-14384:
-------------------------------
Description:
In ValidationMatcher we use failMsg to test exception. However the sql can be
validated successfully without throwing a exception and #matches method returns
true finally.
Take #testInsertWithInvalidPartitionColumns as an example, you can succeed this
tests even though you create a wrong failMsg.
was:
In ValidationMatcher we use failMsg to test exception. However the sql can be
validated successfully without throwing a exception and #matches method returns
true finally.
Take ```testInsertWithInvalidPartitionColumns``` as an example, you can succeed
this tests even though you create a wrong failMsg.
> ValidationMatcher in FlinkSqlParserImplTest fails to test negative tests
> ------------------------------------------------------------------------
>
> Key: FLINK-14384
> URL: https://issues.apache.org/jira/browse/FLINK-14384
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Affects Versions: 1.9.0
> Reporter: Jiayi Liao
> Priority: Major
> Labels: test-stability
>
> In ValidationMatcher we use failMsg to test exception. However the sql can be
> validated successfully without throwing a exception and #matches method
> returns true finally.
>
> Take #testInsertWithInvalidPartitionColumns as an example, you can succeed
> this tests even though you create a wrong failMsg.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
