danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table
SQL] Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334311147
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
##########
@@ -57,12 +60,15 @@
private final SqlNodeList propertyList;
+ @Nullable
Review comment:
`primaryKeyList` default is an empty list[1], also is `uniqueKeysList`[2], i
agree the code is not that intuitive, i would make some refactoring if i have
time.
[1]
https://github.com/apache/flink/blob/dbe1bfa31db4a561b6faa9c1235f02dc130825ca/flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl#L100
[2]https://github.com/apache/flink/blob/dbe1bfa31db4a561b6faa9c1235f02dc130825ca/flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java#L316
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
