GJL commented on a change in pull request #9778: [FLINK-14206][runtime] Let
fullRestart metric count both full restarts and fine grained restarts
URL: https://github.com/apache/flink/pull/9778#discussion_r334792936
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/metrics/NumberOfFullRestartsGauge.java
##########
@@ -42,6 +42,6 @@ public NumberOfFullRestartsGauge(ExecutionGraph
executionGraph) {
@Override
public Long getValue() {
- return eg.getNumberOfFullRestarts();
Review comment:
It would be good to deprecate or even remove `getNumberOfFullRestarts()` I
think `testRestartWithSlotSharingAndNotEnoughResources()` is problematic
because it relies on multi-threading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
