AHeise commented on a change in pull request #9772: [FLINK-14199] Only use
dedicated/named classes for mailbox letters.
URL: https://github.com/apache/flink/pull/9772#discussion_r334980180
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java
##########
@@ -111,11 +111,11 @@ public boolean hasMail() {
//------------------------------------------------------------------------------------------------------------------
@Override
- public void putMail(@Nonnull Runnable letter, int priority) throws
MailboxStateException {
+ public void putMail(@Nonnull Runnable letter, int priority, Object
description) throws MailboxStateException {
final ReentrantLock lock = this.lock;
lock.lock();
try {
- putTailInternal(new Mail(letter, priority));
+ putTailInternal(new Mail(letter, priority,
description));
Review comment:
I will make TaskMailbox symmetric. In fact, that may result in some larger
cleanup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
