xintongsong commented on issue #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics URL: https://github.com/apache/flink/pull/9801#issuecomment-542304107 > @xintongsong > One more question, should we also split `ResourceProfile.managedMemoryInMB` here into the heap/off-heap and assign them for `slotsPerWorker` from the `TaskExecutorResourceSpec` in `ResourceManager#createWorkerSlotProfiles`. We will need it to match `ResourceSpec` against available `slotsPerWorker` in FLIP-53 as I understand. Also, it would help to use different types of memory to init memory manager per slot according to its profile. I actually made that change when implementing FLINK-14188. I think you're right, updating fields of ResourceProfile / ResourceSpec to align with the TaskExecutor memory fields should belong to FLIP-49, and we need that for FLIP-53. I would say we keep the scope of this PR as it is, because it's already quite large and has been reviewed a lot. We can create a new issue for updating ResourceProfile/ResourceSpec under FLIP-49, and get it reviewed independently. Since I already have the code, there shouldn't be much extra work. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
