zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime]
Let fullRestart metric count both full restarts and fine grained restarts
URL: https://github.com/apache/flink/pull/9778#discussion_r335262721
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/metrics/NumberOfFullRestartsGauge.java
##########
@@ -42,6 +42,6 @@ public NumberOfFullRestartsGauge(ExecutionGraph
executionGraph) {
@Override
public Long getValue() {
- return eg.getNumberOfFullRestarts();
Review comment:
For `testRestartWithSlotSharingAndNotEnoughResources` (as well as
`testRestartWithEagerSchedulingAndSlotSharing`), I think the multi-threading
assumption for the `executor` is not needed anymore. It might be introduced due
to some legacy implementation.
The case and related production code has evolved several times. And they
work well now without that assumption. Besides that, with JM thread refactoring
this `executor` is not used for scheduling any more.
We can make the `executor` single threaded and remove the checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
