buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL]
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r335294243
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
##########
@@ -129,7 +133,7 @@ public boolean isIfNotExists() {
public void validate() throws SqlValidateException {
Set<String> columnNames = new HashSet<>();
- if (columnList != null) {
+ if (columnList.size() > 0) {
Review comment:
@dawidwys
Yes. I leave them here just for a better code readability and I don't mind
removing them here. Do you want to remove them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
