azagrebin commented on a change in pull request #9910: [FLINK-14405][runtime]
Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory
setups.
URL: https://github.com/apache/flink/pull/9910#discussion_r335530714
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
##########
@@ -367,6 +417,11 @@ public ResourceProfile merge(@Nonnull ResourceProfile
other) {
return UNKNOWN;
}
+ double resultCpuCores = cpuCores + other.cpuCores;
Review comment:
Why do we remove `addNonNegativeDoublesConsideringOverflow` instead of
changing it?
This change should be a separate hotfix or better issue, looks unrelated.
same for `subtractDoublesConsideringInf `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
