bowenli86 commented on a change in pull request #9908: [FLINK-14401][table][hive] create FunctionDefinitionUtil to instantiate regular java class-based udf and add HiveFunctionDefinitionFactory to instantiate both flink and hive udf URL: https://github.com/apache/flink/pull/9908#discussion_r336598770
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/factories/HiveFunctionDefinitionFactory.java ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog.hive.factories; + +import org.apache.flink.api.java.typeutils.GenericTypeInfo; +import org.apache.flink.connectors.hive.HiveTableFactory; +import org.apache.flink.table.api.TableException; +import org.apache.flink.table.catalog.CatalogFunction; +import org.apache.flink.table.catalog.config.CatalogConfig; +import org.apache.flink.table.catalog.hive.client.HiveShim; +import org.apache.flink.table.catalog.hive.client.HiveShimLoader; +import org.apache.flink.table.catalog.hive.descriptors.HiveCatalogValidator; +import org.apache.flink.table.factories.FunctionDefinitionFactory; +import org.apache.flink.table.functions.FunctionDefinitionUtil; +import org.apache.flink.table.functions.AggregateFunctionDefinition; +import org.apache.flink.table.functions.FunctionDefinition; +import org.apache.flink.table.functions.ScalarFunctionDefinition; +import org.apache.flink.table.functions.TableFunctionDefinition; +import org.apache.flink.table.functions.hive.HiveFunctionWrapper; +import org.apache.flink.table.functions.hive.HiveGenericUDAF; +import org.apache.flink.table.functions.hive.HiveGenericUDF; +import org.apache.flink.table.functions.hive.HiveGenericUDTF; +import org.apache.flink.table.functions.hive.HiveSimpleUDF; +import org.apache.flink.types.Row; + +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.ql.exec.UDAF; +import org.apache.hadoop.hive.ql.exec.UDF; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFEvaluator; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFResolver2; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDF; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDTF; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * A factory to instantiate Hive UDFs as Flink UDFs. + */ +public class HiveFunctionDefinitionFactory implements FunctionDefinitionFactory { + private static final Logger LOG = LoggerFactory.getLogger(HiveTableFactory.class); + + private final String hiveVersion; + private final HiveShim hiveShim; + + public HiveFunctionDefinitionFactory(HiveConf hiveConf) { + // this has to come from hiveConf, otherwise we may lose what user specifies in the yaml file + this.hiveVersion = checkNotNull(hiveConf.get(HiveCatalogValidator.CATALOG_HIVE_VERSION), + "Hive version is not defined"); + this.hiveShim = HiveShimLoader.loadHiveShim(hiveVersion); + } + + @Override + public FunctionDefinition createFunctionDefinition(String name, CatalogFunction catalogFunction) { Review comment: I'm leaning towards not doing that now because we don't assert on any catalog table/view/partition/db objects currently. If it turns out we need to go that route, we'd better update them all at once in the future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
