TisonKun commented on issue #9972: [FLINK-14496][client] Exclude detach flag from ClusterClient URL: https://github.com/apache/flink/pull/9972#issuecomment-545076785 The follow ups I'd like to propose as below. 1. Change `CompletableFuture<JobSubmissionResult> submitJob(JobGraph jobGraph)` to `CompletableFuture<JobID> submitJob(JobGraph jobGraph)` since we always just use the ID. And further, we now never have a `JobSubmissionResult` which is just a wrapper of JobID. We never return a `JobSubmissionResult` in user scope[1] and this help us keep the inheritance tree more clean that `JobSubmissionResult` is no used any more but happens to be a `@Public` interface and has a subclass `JobExecutionResult`. 2. Finish the job towards a `ClusterClient` interface which is an asynchronous version. We now doesn't have any field and all blocking operation can be change to their naturally asynchronous version, while let the caller calls `get` on the future. I don't stick to 1 but during this pull request I think it is nice to have. I'm open to your opinion. 2 is the prerequisite to introduce a `JobClient` interface so that I think FLIP-73 can make use of in the integration work.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
