Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r42248976
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
---
@@ -102,4 +112,18 @@ public void run(SourceContext<OUT> ctx) throws
Exception {
public void cancel() {
running = false;
}
+
+ @Override
+ protected void acknowledgeIDs(List<Long> ids) {
+ try {
+ channel.basicAck(ids.get(ids.size() - 1), true);
+ } catch (IOException e) {
+ e.printStackTrace();
--- End diff --
Exceptions should never be swallowed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
