JingsongLi commented on a change in pull request #9909: [FLINK-14381][table]
Partition field names should be got from CatalogTable instead of source/sink
URL: https://github.com/apache/flink/pull/9909#discussion_r338857716
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/internal/BatchTableEnvImpl.scala
##########
@@ -118,13 +117,12 @@ abstract class BatchTableEnvImpl(
// translate the Table into a DataSet and provide the type that the
TableSink expects.
val result: DataSet[T] = translate(table)(outputType)
// Give the DataSet to the TableSink to emit it.
- batchSink.emitDataSet(shuffleByPartitionFieldsIfNeeded(batchSink,
result))
Review comment:
first, The former logic is to add shuffle no matter whether it is a static
partition or not.
second, after we remove `getPartitionFields` from `PartitionableTableSink`,
here, we can not get the partitions fields. At present, I don't want to
optimize dynamic partition shuffle on legacy planner again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
