ifndef-SleePy commented on a change in pull request #9853:
[FLINK-13904][checkpointing] Avoid competition of checkpoint triggering
URL: https://github.com/apache/flink/pull/9853#discussion_r338879934
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -153,8 +155,8 @@
/** A handle to the current periodic trigger, to cancel it when
necessary. */
private ScheduledFuture<?> currentPeriodicTrigger;
- /** The timestamp (via {@link System#nanoTime()}) when the last
checkpoint completed. */
- private long lastCheckpointCompletionNanos;
+ /** The relative timestamp when the next checkpoint could be triggered.
*/
+ private long earliestRelativeTimeNextCheckpointBeTriggered;
Review comment:
I think the problem is this field includes too much meaning. So it's not
easy to give it a short and clear name. I reverted this field back to
`lastCheckpointCompletionRelativeTime`. Calculates the
`nextCheckpointTriggerRelativeTime` in `checkMinPauseBetweenCheckpoints`, it's
much easier to understand with context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
