GJL commented on a change in pull request #9902: [FLINK-14363][runtime] Prevent
vertex from being affected by outdated deployment
URL: https://github.com/apache/flink/pull/9902#discussion_r338926427
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java
##########
@@ -355,15 +356,51 @@ public void handleGlobalFailure() {
assertThat(deployedExecutionVertices,
contains(executionVertexId, executionVertexId));
}
+ @Test
+ public void vertexIsNotAffectedByOutdatedDeployment() {
+ final JobGraph jobGraph = singleJobVertexJobGraph(2);
+
+ testExecutionSlotAllocator.disableAutoCompletePendingRequests();
+ final DefaultScheduler scheduler =
createSchedulerAndStartScheduling(jobGraph);
+
+ final Iterator<ArchivedExecutionVertex> vertexIterator =
scheduler.requestJob().getAllExecutionVertices().iterator();
+ final ArchivedExecutionVertex v1 = vertexIterator.next();
+ final ArchivedExecutionVertex v2 = vertexIterator.next();
+
+ final SchedulingExecutionVertex sv1 =
scheduler.getSchedulingTopology().getVertices().iterator().next();
+
+ // fail v1 and let it recover to SCHEDULED
Review comment:
maybe add as a comment that the initial deployment of v1 will be outdated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
