zhijiangW commented on a change in pull request #9993: 
[FLINK-14498][runtime]Introduce NetworkBufferPool#isAvailable() for interacting 
with LocalBufferPool.
URL: https://github.com/apache/flink/pull/9993#discussion_r338959921
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java
 ##########
 @@ -142,14 +147,33 @@ public NetworkBufferPool(
 
        @Nullable
        public MemorySegment requestMemorySegment() {
-               return availableMemorySegments.poll();
+               synchronized (availabilityHelper) {
 
 Review comment:
   We need to adjust the `availableMemorySegments` as common `ArrayDeque` 
instead and `synchronized(availableMemorySegments)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to