bowenli86 commented on a change in pull request #9971: [FLINK-14490][table] Add
methods for interacting with temporary objects
URL: https://github.com/apache/flink/pull/9971#discussion_r339234959
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java
##########
@@ -501,6 +537,11 @@ public void alterTable(CatalogBaseTable table,
ObjectIdentifier objectIdentifier
* does not exist.
*/
public void dropTable(ObjectIdentifier objectIdentifier, boolean
ignoreIfNotExists) {
+ if (temporaryTables.containsKey(objectIdentifier)) {
Review comment:
this behavior feels a bit abnormal to me. Why cannot users drop a catalog
table when a temp table with same name space exist?
Table and temp table creation and deletion should be independent of each
other, e,g, from sql perspective, users should be able to run "CREATE/DROP
TABLE" and "CREATE/DROP TEMP TABLE" independently
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
