JingsongLi commented on a change in pull request #9971: [FLINK-14490][table] 
Add methods for interacting with temporary objects
URL: https://github.com/apache/flink/pull/9971#discussion_r339395831
 
 

 ##########
 File path: 
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java
 ##########
 @@ -501,6 +537,11 @@ public void alterTable(CatalogBaseTable table, 
ObjectIdentifier objectIdentifier
         *                          does not exist.
         */
        public void dropTable(ObjectIdentifier objectIdentifier, boolean 
ignoreIfNotExists) {
+               if (temporaryTables.containsKey(objectIdentifier)) {
 
 Review comment:
   Just curious about this, I took a look to spark:
   ```
      * If a database is specified in `name`, this will drop the table from 
that database.
      * If no database is specified, this will first attempt to drop a 
temporary view with
      * the same name, then, if that does not exist, drop the table from the 
current database.
   ```
   Curious about other databases, I don't know how they behave.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to