kl0u commented on issue #9974: [FLINK-14501][FLINK-14502] Decouple ClusterDescriptor/ClusterSpecification from CommandLine URL: https://github.com/apache/flink/pull/9974#issuecomment-547181779 Thanks for the review @TisonKun ! I integrated your comments, apart from the one for the change to the `DefaultClusterClientServiceLoader`. The reason for that is that there is a (wrapped) exception thrown in the `.next()` of the iterator that we need to catch, but at the same time continue the iteration. To see this "in action" feel free to compile (with and without your change) and run the following end-to-end test: ``` FLINK_DIR=build-target flink-end-to-end-tests/run-single-test.sh "flink-end-to-end-tests/test-scripts/test_state_migration.sh" ``` I will merge as soon as Travis gives the green light.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
