zhijiangW commented on a change in pull request #9993: [FLINK-14498][runtime]Introduce NetworkBufferPool#isAvailable() for interacting with LocalBufferPool. URL: https://github.com/apache/flink/pull/9993#discussion_r340445716
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java ########## @@ -269,6 +267,17 @@ private MemorySegment requestMemorySegmentFromGlobal() throws IOException { if (segment != null) { numberOfRequestedMemorySegments++; return segment; + } else if (isBlocking) { + // if the future is completed before the callback is registered, + // the request thread will wait 2s before polling an available + // segment from the global pool, which is not a big problem. + networkBufferPool.isAvailable().thenRun(() -> { + if (!Thread.holdsLock(availableMemorySegments)) { + synchronized (availableMemorySegments) { + availableMemorySegments.notifyAll(); Review comment: Use availableMemorySegments.notify() instead? There was only one thread waiting and in `LocalBufferPool#recycle` it also use `notify`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services