azagrebin commented on a change in pull request #10034: [FLINK-14400] Shrink scope of MemoryManager from TaskExecutor to slot URL: https://github.com/apache/flink/pull/10034#discussion_r341114688
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java ########## @@ -115,6 +116,8 @@ public TaskManagerServicesConfiguration( this.maxJvmHeapMemory = maxJvmHeapMemory; this.localRecoveryEnabled = checkNotNull(localRecoveryEnabled); this.queryableStateConfig = queryableStateConfig; + + Preconditions.checkArgument(0 < numberOfSlots, "The number of task slots must be greater than 0."); Review comment: True, commit split mess up ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services