zhuzhurk commented on a change in pull request #10067: [FLINK-14375][runtime]
Avoid to notify scheduler about fake or outdated state update
URL: https://github.com/apache/flink/pull/10067#discussion_r342129138
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1248,21 +1251,9 @@ private void processFail(Throwable t, boolean
isCallback, Map<String, Accumulato
releaseAssignedResource(t);
vertex.getExecutionGraph().deregisterExecution(this);
- handlePartitionCleanup(releasePartitions,
releasePartitions);
- if (!isCallback && (current == RUNNING ||
current == DEPLOYING)) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Sending out cancel
request, to remove task execution from TaskManager.");
- }
-
- try {
- if (assignedResource != null) {
-
sendCancelRpcCall(NUM_CANCEL_CALL_TRIES);
- }
- } catch (Throwable tt) {
- // no reason this should ever
happen, but log it to be safe
- LOG.error("Error triggering
cancel call while marking task {} as failed.",
getVertex().getTaskNameWithSubtaskIndex(), tt);
- }
+ if (isLegacyScheduling()) {
+
maybeReleasePartitionsAndSendCancelRpcCall(current, isCallback,
releasePartitions);
Review comment:
Yes. Let's do it in a separate issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
