KurtYoung commented on a change in pull request #9864: [FLINK-14254][table] Introduce FileSystemOutputFormat for batch URL: https://github.com/apache/flink/pull/9864#discussion_r342396703
########## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/GroupedPartitionWriter.java ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.filesystem; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.io.OutputFormat; + +/** + * {@link PartitionWriter} for grouped dynamic partition inserting. It will create a new format + * when partition changed. + * + * @param <T> The type of the consumed records. + */ +@Internal +public class GroupedPartitionWriter<T> implements PartitionWriter<T> { + + private final Context<T> context; + private final PathGenerator pathGenerator; + private final PartitionComputer<T> computer; + private final PartitionPathMaker maker; + + private OutputFormat<T> currentFormat; + private String currentPartition; + + public GroupedPartitionWriter( + Context<T> context, + PathGenerator pathGenerator, + PartitionComputer<T> computer, + PartitionPathMaker maker) { + this.context = context; + this.pathGenerator = pathGenerator; + this.computer = computer; + this.maker = maker; + } + + @Override + public void write(T in) throws Exception { + String partition = maker.makePartitionPath(computer.makePartitionValues(in)); + if (currentPartition == null || !partition.equals(currentPartition)) { Review comment: partition.equals(null) will be false, no? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
