guoweiM commented on a change in pull request #10076: [FLINK-14465][runtime]
Let `StandaloneJobClusterEntrypoint` use user code class loader
URL: https://github.com/apache/flink/pull/10076#discussion_r342405496
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterEntryPoint.java
##########
@@ -74,10 +79,20 @@ private StandaloneJobClusterEntryPoint(
}
@Override
- protected DispatcherResourceManagerComponentFactory
createDispatcherResourceManagerComponentFactory(Configuration configuration) {
+ protected DispatcherResourceManagerComponentFactory
createDispatcherResourceManagerComponentFactory(Configuration configuration)
throws IOException {
+ final String flinkHomeDir = System.getenv(ENV_FLINK_HOME_DIR);
Review comment:
1. I have verified it. (Running /test_docker_embedded_job.sh and manually
package the per-job docker image and run) . I see this value in
`ConfigConstants`. So I thought it was a contract.
1. Since you said this is not a contract, I would like to propose not to
rely on `FLINK_HOME`
1. One possible approach is:
1. We could try the ENV_FLINK_USR_LIB_DIR directory first
1. if this dir does not exsits we could try the UsrLib directory
relative to WorkingDir.
By the way
This requires modifying the working dir in docker-entrypoint.sh to support
the default behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
