pnowojski commented on a change in pull request #10009: [FLINK-14304] Avoid task starvation with mailbox URL: https://github.com/apache/flink/pull/10009#discussion_r342962212
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java ########## @@ -211,26 +215,27 @@ private void checkTakeStateConditions() { @Override public void quiesce() { + final ReentrantLock lock = this.lock; Review comment: Ok, let's keep it as a black magic. I've read the explanation why it actually may help (`final` fields are useless in JVM, but `final` local variables can actually work as they are truly immutable). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services