KurtYoung commented on a change in pull request #10096:
[FLINK-14623][table-api] Add computed column information into TableSc…
URL: https://github.com/apache/flink/pull/10096#discussion_r342988946
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
##########
@@ -423,17 +525,15 @@ public Builder watermark(String rowtimeAttribute, String
watermarkExpressionStri
throw new IllegalStateException("Multiple
watermark definition is not supported yet.");
}
this.watermarkSpecs.add(new
WatermarkSpec(rowtimeAttribute, watermarkExpressionString,
watermarkExprOutputType));
+ validateWatermarkSpecs(this.columns,
this.watermarkSpecs);
Review comment:
ditto: validate this in `build()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
