TisonKun opened a new pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104 ## What is the purpose of the change Refactor ScalaShellRemote(Stream)Environment to simplify inheritance ## Brief change log - ScalaShellRemoteEnvironment directly inherits from RemoteEnvironment - ScalaShellRemoteStreamEnvironment directly inherits from RemoteStreamEnvironment - Get rid of mock tests ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes, methods in Environments, I think no one should depend on the methods modified. In another perspective, @Public in class doesn't mean in its methods.) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
