docete commented on a change in pull request #10105:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10105#discussion_r343554982
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -455,13 +465,15 @@ object GenerateUtils {
def generateRowtimeAccess(
ctx: CodeGeneratorContext,
contextTerm: String): GeneratedExpression = {
+ val resultType = new TimestampType(true, TimestampKind.ROWTIME, 3)
Review comment:
IMO rowtime and proctime should be Timestamp(3) and keep millisecond
precision.
Is it necessary to support higher precision rowtime and proctime?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
