KurtYoung commented on a change in pull request #10022: [FLINK-14135][orc] Introduce OrcColumnarRowInputFormat URL: https://github.com/apache/flink/pull/10022#discussion_r343999593
########## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/vector/VectorizedColumnBatch.java ########## @@ -123,7 +123,10 @@ public Decimal getDecimal(int rowId, int colId, int precision, int scale) { return null; } - if (Decimal.is32BitDecimal(precision)) { + ColumnVector column = columns[colId]; Review comment: add tests to cover decimal in VectorizedColumnBatch ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services