dawidwys edited a comment on issue #10117: [FLINK-14494][docs] Add ConfigOption 
type to the documentation generator
URL: https://github.com/apache/flink/pull/10117#issuecomment-551539344
 
 
   Thank you @zentol for your review. Here is a screenshot of an enum option:
   
   
![image](https://user-images.githubusercontent.com/6242259/68469842-44364000-021b-11ea-90c7-fcca4926eeae.png)
   
   The problem with `String` in most of the rows is that the value of this 
column is based on the functionality introduced in 
https://issues.apache.org/jira/browse/FLINK-14493, where we should provide the 
type explicitly. So far all the memory, duration options were actually of type 
string and the parsing happened in place where the option was accessed. I can 
not see a way to change the type automatically without changing the 
corresponding `ConfigOption` and all the places it is accessed. A workaround I 
can see is to enable this column manually only for groups that have all the 
ConfigOptions updated. Do you think this would be a better approach?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to