KurtYoung commented on a change in pull request #10123:
[FLINK-14665][table-planner-blink] Support computed column for create…
URL: https://github.com/apache/flink/pull/10123#discussion_r344424833
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/PhysicalTableSourceScan.scala
##########
@@ -53,8 +52,9 @@ abstract class PhysicalTableSourceScan(
protected[flink] val tableSource: TableSource[_] =
tableSourceTable.tableSource
override def deriveRowType(): RelDataType = {
- val flinkTypeFactory =
cluster.getTypeFactory.asInstanceOf[FlinkTypeFactory]
- tableSourceTable.getRowType(flinkTypeFactory)
+ // TableScan row type should always keep same with its
Review comment:
Not sure about this, if we had project pushed down, will the row type still
the same with the table's?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
