zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r344539902
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureStatsTrackerImpl.java
##########
@@ -82,19 +87,21 @@
/**
* Creates a back pressure statistics tracker.
*
- * @param cleanUpInterval Clean up interval for completed stats.
- * @param backPressureStatsRefreshInterval
+ * @param coordinator Coordinator for back pressure stats request.
+ * @param cleanUpInterval Clean up interval for completed stats.
+ * @param refreshInterval Time interval after which the available back
pressure
+ * stats are deprecated and need to be refreshed.
*/
public BackPressureStatsTrackerImpl(
BackPressureRequestCoordinator coordinator,
int cleanUpInterval,
- int backPressureStatsRefreshInterval) {
+ int refreshInterval) {
Review comment:
Should also check argument for `cleanUpInterval`. Or add `@Nonnegative` for
`cleanUpInterval` and `refreshInterval` to replace check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
