TisonKun commented on a change in pull request #10143: [FLINK-13184]Starting a
TaskExecutor blocks the YarnResourceManager's main thread
URL: https://github.com/apache/flink/pull/10143#discussion_r344598205
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -844,14 +844,16 @@ private ApplicationReport startAppMaster(
tmpConfigurationFile.deleteOnExit();
BootstrapTools.writeConfiguration(configuration,
tmpConfigurationFile);
+ String flinkConfigKey = "flink-conf.yaml";
Path remotePathConf = setupSingleLocalResource(
- "flink-conf.yaml",
+ flinkConfigKey,
fs,
appId,
new
Path(tmpConfigurationFile.getAbsolutePath()),
localResources,
homeDir,
"");
+
envShipFileList.append(flinkConfigKey).append("=").append(remotePathConf).append(",");
Review comment:
I'm curious this line. `envShipFileList` configures files ship on TM. With
this line we actually ship `flink-conf.yaml` to TM even if we remove it from
code diff above. What is your decision on whether or not ship `flink-conf.yaml`
indeed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
